Added autoSortReleases to Changelog and parser
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarotero
requested changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks!
I like the feature but not convinced about the implementation, so I left a comment with another approach :). Let me know what you think.
Regarding formatting, deno fmt should be used. In my computer it does some changes, so make sure you have an up to date Deno version.
Changes in CHANGELOG.md are added in the example.ts file (but I just realized that I forgot to update and run the script in the last release!). I think you can edit the 2.6.0 version in example.ts (that never was released) and add your changes there.
oscarotero
requested changes
Feb 20, 2025
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added option to disable automatically sorting releases in parser and changelog.
This would allow to preserve original order of releases in changelog file and allow to be used in CI/CD pipeline to check if user properly ordered changelog versions.
I didn't add this functionality to bin.ts. If you think it should be added I will gladly add it there.
I also didn't found any guidelines what and when should be added to main changelog file of this library so i didn't add anything for now.
There is also no information how library should be formatted. I think it should be foramatted using
deno fmtbut after running that command there appers to be files not formatted with it. Whatever the case is I can add github actions to run formatter when creating a PR.